search

syscoin / blockmarket-desktop-public

Public location for issue reporting on the Blockmarket Desktop public data, built using Syscoin blockchain technology.
http://blockchainfoundry.co
30 stars 25 forks source link

Console (syscoin-api) in BM 1.1 returns error for certain endpoints #261

Closed johnp1954 closed 6 years ago

johnp1954 commented 6 years ago

Some console cmds do not work for instance importprivate key gives this error.

TypeError: Failed to execute 'fetch' on 'Window': Request with GET/HEAD method cannot have body.

dwasyluk commented 6 years ago

This actually might be an issue with syscoin-api (used by BM). We'll investigate this one.

dwasyluk commented 6 years ago

On further review this impacts several endpoints (none of which are directly used by blockmarket). We'll need to go thru the full list of get requests in syscoin-api and update get requests that improperly use body w/get requests.

sschepis commented 6 years ago

I've updated all APIs which passed in typed data in body but were set to GET to POST. This should fix the issue but it needs a retest

dwasyluk commented 6 years ago

@johnp1954 this should be fixed, please retest and close.

jnessbcf commented 6 years ago

Closing - will split this into separate issues per console command as they are tested.