fix(agent): use dig function for prometheus_exporter settings check

sysdiglabs / charts

The official source for Sysdig’s Helm charts

https://charts.sysdig.com

40 stars 127 forks source link

Closed aroberts87 closed 1 month ago

aroberts87 commented 1 month ago

Migrate the new prometheus_exporter port creation logic to use Helm's 'dig' function to protect against cases where the values may not be present.

[x] Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
[x] Chart Version bumped for the respective charts
[x] Check GithubAction checks (like lint) to avoid merge-check stoppers

francesco-furlan commented 1 month ago

@aroberts87 when was dig introduced? Are we sure to not break older versions of helm?

aroberts87 commented 1 month ago

@aroberts87 when was dig introduced? Are we sure to not break older versions of helm?

@francesco-furlan - The dig function was added in v3.5.0, which is fortunately below our minimum supported version of v3.6.