search

sysdiglabs / kube-apparmor-manager

Manage AppAmormor profiles for Kubernetes cluster
Apache License 2.0
39 stars 5 forks source link

Use InternalIP to connect to nodes. #5

Closed Hunter1016 closed 2 years ago

Hunter1016 commented 2 years ago

Kubelet only ever sets InternalIP itself, based on either --node-ip or the primary interface address of the system.

Signed-off-by: Teng Hu huteng.ht@bytedance.com

Kaizhe commented 2 years ago

Hi, @Hunter1016 thank you for the contribution. I think it depends where the kube-apparmor-manager runs, if it runs inside the same VPC , internal IP works perfectly, if it runs outside the VPC, external IP need to be used. Given that said, do you mind you add a flag to in the cli to decide which IP to use?

Hunter1016 commented 2 years ago

Hi, @Hunter1016 thank you for the contribution. I think it depends where the kube-apparmor-manager runs, if it runs inside the same VPC , internal IP works perfectly, if it runs outside the VPC, external IP need to be used. Given that said, do you mind you add a flag to in the cli to decide which IP to use?

Helpful suggestion, I'll try to add it later.

Kaizhe commented 2 years ago

/lgtm

Kaizhe commented 2 years ago

@Hunter1016 let me know if you can merge, then we can create a new release.

Hunter1016 commented 2 years ago

@Hunter1016 let me know if you can merge, then we can create a new release.

I'm afraid I don't have the right to merge.

StokeGitHub commented 2 years ago

@Kaizhe, Hunter1016 does not seem to have merge access rights. Could you perhaps merge this Pull please? Linked Issue: #4.

Kaizhe commented 2 years ago

@omerazr , thanks a lot! I've already approved it. it would be great that someone from the open source team to merge it and create a new release.

Kaizhe commented 2 years ago

@omerazr , thanks a lot! I've already approved it. it would be great that someone from the open source team to merge it and create a new release.

never mind, I got the invitation :)