search

syself / charts

Helm charts repo
Apache License 2.0
13 stars 4 forks source link

🐛 Missing toleration in csi-hcloud DaemonSet #50

Open Privatecoder opened 1 year ago

Privatecoder commented 1 year ago

/kind bug

What steps did you take and what happened:

When deploying hetzner csi-hcloud:0.3.1 the resulting DaemonSet pods does not have tolerations set correctly.

Should be:

tolerations:
- effect: NoExecute
  operator: Exists
- effect: NoSchedule
  operator: Exists
- key: CriticalAddonsOnly
  operator: Exists

Is:

tolerations:
- effect: NoExecute
  operator: Exists
- key: CriticalAddonsOnly
  operator: Exists

What did you expect to happen:

Missing toleration should be available

- effect: NoSchedule
  operator: Exists
Privatecoder commented 1 year ago

Also csi-hcloud-controller does not obey instance.hetzner.cloud/is-root-server as the original hcloud-csi-controller does: https://github.com/hetznercloud/csi-driver/blob/f7271112c825ba94eba92b003284cb924becddab/deploy/kubernetes/hcloud-csi.yml#L118