search

syself / cluster-api-provider-hetzner

Cluster API Provider Hetzner 🚀 Kubernetes Infrastructure as Software 🔧 Terraform/Kubespray/kOps alternative for running Kubernetes on Hetzner
https://caph.syself.com
Apache License 2.0
540 stars 51 forks source link

🐛Fix flaky reach state image installing test #1287

Closed yrs147 closed 2 months ago

yrs147 commented 2 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1228

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

yrs147 commented 2 months ago

looks good! Were you able to validate that sometimes it actually reaches the state provisioned, or is this more a good guess (also one that I made)?

just asking out of curiousity.

Other than that plz rename commit and PR. this is a bugfix, therefore you can use 🐛

I did come up with this based on what you said to me earlier :)

janiskemper commented 2 months ago

alright so I guess we haven't 100% validated that this fixes it, it's a good hypthosis. An issue might be if "provisioned" is not actually reached but it gets stuck in another state beforehand. If you change the title as I suggested above, we can merge this