search

syself / cluster-api-provider-hetzner

Cluster API Provider Hetzner :rocket: The best way to manage Kubernetes clusters on Hetzner, fully declarative, Kubernetes-native and with self-healing capabilities
https://caph.syself.com
Apache License 2.0
620 stars 58 forks source link

🌱 avoid redacting logs when running e2e tests #1294

Closed kranurag7 closed 4 months ago

kranurag7 commented 5 months ago

We were running a script to redact the token in _artifacts directory which gets produced when we run our e2e tests. Since, ginkgo spec are run one after another, once first spec runs and we redact the logs, the manifest (kind: Secret) gets invalid and we get an error in our e2e tests.

Error from server (BadRequest): error when creating "secret.yaml": Secret in version "v1" cannot be handled as a Secret: illegal base64 data at input byte 0

This commit avoids redacting logs after each spec. We still do it after the whole suite completes.

janiskemper commented 5 months ago

can you explain this change?

kranurag7 commented 5 months ago

can you explain this change?

We were running a script to redact the token in _artifacts directory which gets produced when we run our e2e tests. Since, ginkgo spec are run one after another, once first spec runs and we redact the logs, the manifest (kind: Secret) gets invalid and we get an error in our e2e tests.

Error from server (BadRequest): error when creating "secret.yaml": Secret in version "v1" cannot be handled as a Secret: illegal base64 data at input byte 0

This commit avoids redacting logs after each spec. We still do it after the whole suite completes.