search

syself / cluster-api-provider-hetzner

Cluster API Provider Hetzner 🚀 Kubernetes Infrastructure as Software 🔧 Terraform/Kubespray/kOps alternative for running Kubernetes on Hetzner
https://caph.syself.com
Apache License 2.0
540 stars 51 forks source link

:bug: Fix CSR for ConstantBareMetalHostname #1295

Closed guettli closed 2 months ago

guettli commented 2 months ago

What this PR does / why we need it:

If a cluster uses ConstantBareMetalHostname, then the CSRs were not approved, since the node-name did not match the expected pattern.

This PR extends the CSR approving, so that CSRs for constant bm hostnames get approved.

janiskemper commented 2 months ago

@kranurag7 can you test this and check whether a) hcloud servers get csrs approved b) bare metal servers without constant node name get csrs approved c) bare metal servers with constant node name get csrs approved