search

syself / cluster-api-provider-hetzner

Cluster API Provider Hetzner :rocket: The best way to manage Kubernetes clusters on Hetzner, fully declarative, Kubernetes-native and with self-healing capabilities
https://caph.syself.com
Apache License 2.0
619 stars 58 forks source link

:seedling: Update Update Golang Dependencies group (patch) #1300

Closed syself-bot[bot] closed 3 months ago

syself-bot[bot] commented 4 months ago

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/go-logr/logr v1.4.1 -> v1.4.2 age adoption passing confidence
sigs.k8s.io/controller-runtime v0.17.3 -> v0.17.5 age adoption passing confidence

Release Notes

go-logr/logr (github.com/go-logr/logr) ### [`v1.4.2`](https://togithub.com/go-logr/logr/releases/tag/v1.4.2) [Compare Source](https://togithub.com/go-logr/logr/compare/v1.4.1...v1.4.2) #### What's Changed - Fix lint: named but unused params by [@​thockin](https://togithub.com/thockin) in [https://github.com/go-logr/logr/pull/268](https://togithub.com/go-logr/logr/pull/268) - Add a Go report card, fix lint by [@​thockin](https://togithub.com/thockin) in [https://github.com/go-logr/logr/pull/271](https://togithub.com/go-logr/logr/pull/271) - funcr: Handle nested empty groups properly by [@​thockin](https://togithub.com/thockin) in [https://github.com/go-logr/logr/pull/274](https://togithub.com/go-logr/logr/pull/274) ##### Dependencies: - build(deps): bump github/codeql-action from 3.22.11 to 3.22.12 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/254](https://togithub.com/go-logr/logr/pull/254) - build(deps): bump github/codeql-action from 3.22.12 to 3.23.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/256](https://togithub.com/go-logr/logr/pull/256) - build(deps): bump actions/upload-artifact from 4.0.0 to 4.1.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/257](https://togithub.com/go-logr/logr/pull/257) - build(deps): bump github/codeql-action from 3.23.0 to 3.23.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/259](https://togithub.com/go-logr/logr/pull/259) - build(deps): bump actions/upload-artifact from 4.1.0 to 4.2.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/260](https://togithub.com/go-logr/logr/pull/260) - build(deps): bump actions/upload-artifact from 4.2.0 to 4.3.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/263](https://togithub.com/go-logr/logr/pull/263) - build(deps): bump github/codeql-action from 3.23.1 to 3.23.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/262](https://togithub.com/go-logr/logr/pull/262) - build(deps): bump github/codeql-action from 3.23.2 to 3.24.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/264](https://togithub.com/go-logr/logr/pull/264) - build(deps): bump actions/upload-artifact from 4.3.0 to 4.3.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/266](https://togithub.com/go-logr/logr/pull/266) - build(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/267](https://togithub.com/go-logr/logr/pull/267) - build(deps): bump github/codeql-action from 3.24.0 to 3.24.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/270](https://togithub.com/go-logr/logr/pull/270) - build(deps): bump github/codeql-action from 3.24.3 to 3.24.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/272](https://togithub.com/go-logr/logr/pull/272) - build(deps): bump github/codeql-action from 3.24.5 to 3.24.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/275](https://togithub.com/go-logr/logr/pull/275) - build(deps): bump actions/checkout from 4.1.1 to 4.1.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/276](https://togithub.com/go-logr/logr/pull/276) - build(deps): bump github/codeql-action from 3.24.6 to 3.24.7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/277](https://togithub.com/go-logr/logr/pull/277) - build(deps): bump github/codeql-action from 3.24.7 to 3.24.9 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/278](https://togithub.com/go-logr/logr/pull/278) - build(deps): bump github/codeql-action from 3.24.9 to 3.24.10 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/279](https://togithub.com/go-logr/logr/pull/279) - build(deps): bump actions/upload-artifact from 4.3.1 to 4.3.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/280](https://togithub.com/go-logr/logr/pull/280) - build(deps): bump actions/checkout from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/281](https://togithub.com/go-logr/logr/pull/281) - build(deps): bump github/codeql-action from 3.24.10 to 3.25.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/282](https://togithub.com/go-logr/logr/pull/282) - build(deps): bump github/codeql-action from 3.25.1 to 3.25.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/283](https://togithub.com/go-logr/logr/pull/283) - build(deps): bump golangci/golangci-lint-action from 4.0.0 to 5.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/284](https://togithub.com/go-logr/logr/pull/284) - build(deps): bump actions/checkout from 4.1.3 to 4.1.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/285](https://togithub.com/go-logr/logr/pull/285) - build(deps): bump actions/upload-artifact from 4.3.2 to 4.3.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/286](https://togithub.com/go-logr/logr/pull/286) - build(deps): bump actions/setup-go from 5.0.0 to 5.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/288](https://togithub.com/go-logr/logr/pull/288) - build(deps): bump golangci/golangci-lint-action from 5.0.0 to 5.3.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/289](https://togithub.com/go-logr/logr/pull/289) - build(deps): bump golangci/golangci-lint-action from 5.3.0 to 6.0.1 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/293](https://togithub.com/go-logr/logr/pull/293) - build(deps): bump github/codeql-action from 3.25.3 to 3.25.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/292](https://togithub.com/go-logr/logr/pull/292) - build(deps): bump actions/checkout from 4.1.4 to 4.1.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/291](https://togithub.com/go-logr/logr/pull/291) - build(deps): bump ossf/scorecard-action from 2.3.1 to 2.3.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/290](https://togithub.com/go-logr/logr/pull/290) - build(deps): bump github/codeql-action from 3.25.4 to 3.25.5 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/294](https://togithub.com/go-logr/logr/pull/294) - build(deps): bump actions/checkout from 4.1.5 to 4.1.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/go-logr/logr/pull/295](https://togithub.com/go-logr/logr/pull/295) **Full Changelog**: https://github.com/go-logr/logr/compare/v1.4.1...v1.4.2
kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime) ### [`v0.17.5`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.17.5) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.17.4...v0.17.5) #### What's Changed - 🐛 Reintroduce AddMetricsServerExtraHandler on manager by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2815](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2815) **Full Changelog**: https://github.com/kubernetes-sigs/controller-runtime/compare/v0.17.4...v0.17.5 ### [`v0.17.4`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.17.4) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.17.3...v0.17.4) #### What's Changed - \[release-0.17] ✨ client: Add client-wide fieldManager by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2772](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2772) - \[release-0.17] :bug: Cache: Fix label defaulting of byObject when namespaces are configured by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [https://github.com/kubernetes-sigs/controller-runtime/pull/2807](https://togithub.com/kubernetes-sigs/controller-runtime/pull/2807) **Full Changelog**: https://github.com/kubernetes-sigs/controller-runtime/compare/v0.17.3...v0.17.4

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

kranurag7 commented 4 months ago

cluster API is still using v0.17.3 version of controller-runtime so I think we shouldn't go ahead of upstream CAPI for now.

https://github.com/kubernetes-sigs/cluster-api/blob/512dc36da7fa818f7636c18c0b04342c5c59e511/go.mod#L49

kranurag7 commented 3 months ago

I think we should disable patch updates for controller-runtime as well.

https://github.com/syself/cluster-api-provider-hetzner/blob/c25ce61b81e1b39e9e34d9e9bafca26fa34b5418/.github/renovate/golang.json5#L24-L30

janiskemper commented 3 months ago

go ahead @kranurag7

kranurag7 commented 3 months ago

go ahead @kranurag7

no I think the current workflow is fine, it's okay to have patch updates of controller-runtime.