search

syself / cluster-api-provider-hetzner

Cluster API Provider Hetzner 🚀 Kubernetes Infrastructure as Software 🔧 Terraform/Kubespray/kOps alternative for running Kubernetes on Hetzner
https://caph.syself.com
Apache License 2.0
539 stars 51 forks source link

Support for the new cloud servers #1366

Closed PlayMTL closed 1 week ago

PlayMTL commented 1 week ago

⚠️ Cluster API Hetzner maintainers can ask to turn an issue-proposal into a CAEP when necessary. This is to be expected for large changes that impact multiple components, breaking changes, or new large features.

Goals Hetzner reworked their Intel based cloud server lineup (https://www.hetzner.com/cloud/). (Also looks like they deprecated some of their old configs, but they are still available via api). The goal is to support the new cloud server configurations:

User Story

As a user I would like to use the new intel cloud server lineup for my capi cluster.

Detailed Description

The new server types should be configurable and usable for the endusers of the provider. I found a validation string which might need to be updated: https://github.com/syself/cluster-api-provider-hetzner/blob/e6e5e7710a0bcd646a332a03273268c24f2cb5f7/api/v1beta1/hcloudmachine_types.go#L40

Contract changes [optional] %

Data model changes [optional] %

/kind proposal

kranurag7 commented 1 week ago

@PlayMTL I think this is already supported via https://github.com/syself/cluster-api-provider-hetzner/pull/1330 and we released new version after that so you can use latest release and that should work.

we plan to remove old server types once hetzner removes it from their API which is on September 6th 2024

ping me again if this doesn't answer your question.

PlayMTL commented 1 week ago

OMG, I'm sorry. You are completely right, i was on the release before... :( It works, I also didn't check the end of the validation line...

kranurag7 commented 1 week ago

No worries at all. Please open issues anytime if something doesn't work right.

FYI, we have launched new docs today at https://caph.syself.com/ which might be helpful to you if you're using CAPH. (I'll try to get the server type added into the docs as well)