Manifest icon asset src - Githubissues

sysgears / apollo-universal-starter-kit

Apollo Universal Starter Kit is a SEO-friendly, fully-configured, modular starter application that helps developers to streamline web, server, and mobile development with cutting-edge technologies and ultimate code reuse.

https://apollokit.org

MIT License

1.68k stars 323 forks source link

Manifest icon asset src #1077

Open zirho opened 5 years ago

zirho commented 5 years ago

Shouldn't the icon src be hashed in manifest.xjson?

https://github.com/sysgears/apollo-universal-starter-kit/blob/master/modules/favicon/common/assets/manifest.xjson#L5

It seems broken to me in the example heroku site https://apollo-universal-starter-kit.herokuapp.com/

This is what is expected.

To Reproduce Steps to reproduce the behavior:

Go to https://apollo-universal-starter-kit.herokuapp.com/
navigate to Manifest tab in chrome debugging tool https://developers.google.com/web/fundamentals/web-app-manifest/
see empty icon section.

larixer commented 5 years ago

@zirho I think to fix this issue we should use val-loader: https://github.com/webpack-contrib/val-loader

beingtmk commented 4 years ago

@larixer, How do you suggest doing it with val-loader?

Can we fix it by not hashing it for now, like it is done with favicon.ico?