search

sysgears / mochapack

Mocha test runner with integrated webpack precompiler
https://sysgears.github.io/mochapack/
MIT License
183 stars 28 forks source link

Fix --file not being respected #84

Closed willsoto closed 3 years ago

willsoto commented 3 years ago

What's the problem this PR addresses?

--file not being respected

How did you fix it?

Any files that were added via --file were being blown away when Webpack's entrypoints were being added. In order to resolve this, the entrypoints now get added via Mocha's addFile method.

Closes #20

larixer commented 3 years ago

@willsoto Nice, many thanks!

larixer commented 3 years ago

Published in mochapack@2.0.4

willsoto commented 3 years ago

Thanks for the quick review and release!

willsoto commented 3 years ago

@larixer It doesn't seem like the change made it into 2.0.4. I just upgraded but the compiled code does not contain the change I made.

Screen Shot 2020-10-16 at 9 58 10 AM Screen Shot 2020-10-16 at 9 58 15 AM
larixer commented 3 years ago

@willsoto Could you check if it came through into 2.0.5 ?

Yarn 2 does not use prepublishOnly script, it uses prepack script instead, I have adjusted that

willsoto commented 3 years ago

@larixer - works now. Thank you very much!

larixer commented 3 years ago

@willsoto Thank you!