search

sysgears / spinjs

SpinJS is now Zen! The project has been renamed and moved to Larix Framework.
https://github.com/sysgears/larix/tree/master/packages/zen
MIT License
43 stars 8 forks source link

webpack dev server options #6

Closed verdverm closed 6 years ago

larixer commented 6 years ago

@verdverm Looks good, but lets add docs as well for the new options into README.md

verdverm commented 6 years ago

Added some docs; also removed one line that was a duplicate

larixer commented 6 years ago

@verdverm https shouldn't automatically mean 443 port. It means port 443 but if port is omitted from the string. Kinda the same as http and 80. I think this part of pull request should be amended

verdverm commented 6 years ago

@vlasenko I was thinking about that as I wrote it. Cleaned it up, if protocol and port match (for both http(s)), then it will omit it for aesthetics.

larixer commented 6 years ago

@verdverm Looks good, thank you! Merged it

larixer commented 6 years ago

@verdverm Published as spinjs@0.4.161