Moon jump cheat code is full of errors

[GoogleCodeExporter]

Describe your system:
 - Operating System (be specific): Arch Linux Kernel 3.8.4-1
 - Machine type (32-bit or 64-bit): 64-bit
 - Mupen64Plus version: 1.99.5
- Plugins used:
   Video = Mupen64Plus OpenGL Video Plugin by Rice
   Audio = Mupen64Plus SDL Audio Plugin
   Input = Mupen64Plus SDL Input Plugin
   RSP = Hacktarux/Azimer High-Level Emulation RSP Plugin

For visual artifacts, give:
 - game name and CRC/MD5 hash (printed on console): Super Mario 64 (MD5: 20B854B239203BAF6C961B850A4A51A2) (CRC: 635a2bff 8b022326) (Image type: .z64)

- description of the artifact (missing polygons, flashing, wrong colors,
etc): Moon jump cheat code error.

Describe the problem:
The moon jump cheat code in this game causes weird things to happen. When I do 
long jump (Z and A) mario jumps in the air causing the long jump to be shorter, 

When I get a star, mario jumps once and doesn't dance and nothing happens in 
the game, i had to fall off a clif to get out of the course.

It also spoils wall kicks the same way it spoils the long jump (Z and A).

Please provide any additional information below:
Though, I cannot provide a workaround, but, whatever the moon jump code 
mupen64plus uses, replace it with this code (worked on Project64):
D033AFA1 0020
8133B1BC 4220
D033AFA1 0020
8133B17C 0300
D033AFA1 0020
8133B17E 0880

Original issue reported on code.google.com by ormie.su...@gmail.com on 31 Mar 2013 at 5:21

[GoogleCodeExporter]

Can you please veri:fy that your cheat code stuff works? M64P currently uses 
(according to mupen64plus.cht) D033AFA1 0020,8133B1BC 4220,D033B1BD 
0020,8133B17C 0300,D033B1BD 0020,8133B17E 0880. Please replace it (+give 
feedback) with D033AFA1 0020,8133B1BC 4220,D033AFA1 0020,8133B17C 0300,D033AFA1 
0020,8133B17E 0880

Original comment by s...@narfation.org on 31 Mar 2013 at 12:51

[GoogleCodeExporter]

I've tried uncommenting the old one and create a new one at the same cheat code 
number as the old one, i've tried adding the code, but, m64p is ignoring it. 
That's why i said "There's no work around".

Original comment by ormie.su...@gmail.com on 1 Apr 2013 at 2:31

[GoogleCodeExporter]

But you said we should replace it with something else (which implies that the 
new one should work)? And now you are saying the new one also doesn't work. 
Sry, but this doesn't make sense for me.

Original comment by s...@narfation.org on 1 Apr 2013 at 4:09

[GoogleCodeExporter]

well, i said:
i tried to add the new code in the mupen64plus.cht file and replacing the old 
code... But, when I play SM64 on M64P after that, m64P still uses the same code 
instead of the new code i used.

 That's why i said there's no work around.

Original comment by ormie.su...@gmail.com on 2 Apr 2013 at 2:12

[GoogleCodeExporter]

The code is not stored in this file. mupencheat.txt is the right one. The other 
one is just the source file for mupencheat.txt. You can convert them using (in 
mupen64plus-core/tools)

python2 code_convert.py > ../data/mupencheat.txt < ../data/mupen64plus.cht

Original comment by s...@narfation.org on 29 Jan 2014 at 7:02

[GoogleCodeExporter]

Copy and paste error. I've meant

python2 cheat_code_convert.py > ../data/mupencheat.txt < ../data/mupen64plus.cht

But I've tested your recommendation to use the same the same precondition for 
each write in the cheatcode and it really looks better. At least when I've 
checked the problems that you've mentioned.

The change is queued up as 
https://github.com/ecsv/mupen64plus-core/commit/fa280a6b4e630407dd3831cec8e0a901
a43e55e5

Original comment by s...@narfation.org on 29 Jan 2014 at 9:13

Attachments:

• 0001-Use-same-precondition-for-all-parts-of-the-Mario64-L.patch

[GoogleCodeExporter]

Before I forget: Please also forward it to Project64

Original comment by s...@narfation.org on 29 Jan 2014 at 9:50