sysown / proxysql

High-performance MySQL proxy with a GPL license.
http://www.proxysql.com
GNU General Public License v3.0
6.05k stars 983 forks source link

Fix clang compilation for tests dep 'cppdotenv' #4468

Closed JavierJF closed 8 months ago

JavierJF commented 8 months ago

Minimal changes for fixing the cppdotenv compilation under clang. Removes an unnecessary using directive since fully qualified names are used within the file anyway.

Extra details

There is another potential solution, that involves fixing all the ambiguities that arise when the namespace is included in the global one by the using directive. Several changes are required within the same file, for fixing these ambiguities, clang appears more sensitive that gcc and requires a full path from global namespace :: for being able to do proper name resolution. It's left here as no more than an interesting read:

nm_clang_fix_fqualified.txt

mirostauder commented 8 months ago

added fixes based on CLang warnings:

other:

ASAN breaks with ASLR > 28bits used by recent kernels https://github.com/google/sanitizers/issues/1716

mirostauder commented 8 months ago

retest this please