search

sysprog21 / rv32emu

Compact and Efficient RISC-V RV32I[MAFC] emulator
MIT License
402 stars 97 forks source link

Bring wasm service up #487

Closed ChinYikMing closed 2 months ago

ChinYikMing commented 2 months ago

After merging https://github.com/sysprog21/rv32emu/pull/474, multiple executables were moved to other location (build/riscv32), which caused the wasm service to fail. The intuitive solution is to embed build/riscv32 into the wasm. Also, executables that stored in rv32emu-prebuilt must be pulled before embedding into wasm, so emcc_deps should depend on the artifact target.

Additionally, the Makefile's distclean target does not fully clean wasm artifacts, as CC=emcc might not be set during make distclean. To fix this, the declaration of the WEB_FILES and DEMO_DIR wasm-related variables has been reordered.

As the number of ELF executables may increase over time, manually updating the HTML ELF list becomes tedious. Therefore, an ELF list generator has been introduced. When new ELF executables are added to the build or build/riscv32 directories, the list will be generated dynamically.

Close: #486

ChinYikMing commented 2 months ago

Clarify the git commit message: if this pull request is able to resolve #486, you should write Close #486 explicitly.

I would close #486 if the ELF selection list generator is being merged. Alternatively, I could update the issue title to simplify tracking.

ChinYikMing commented 2 months ago

I changed to title in #486. The ELF selection list generator is in progress and may take some time. To bring up the WASM service quickly, this PR could be merged first.

jserv commented 2 months ago

Thank @ChinYikMing for contributing!