sysprog21 / semu

A minimalist RISC-V system emulator capable of running Linux kernel
MIT License
247 stars 46 forks source link

Remove extra parentheses #11

Closed bugorz closed 2 years ago

bugorz commented 2 years ago

Note to reviewers

Tests

nothing to commit, working tree clean ➜ semu git:(master) make ENABLE_RISCV_TESTS=1 clean run-tests
CC semu.o CC tests/isa-test.o

(omitted)

Building riscv-tests... riscv64-unknown-elf-objcopy: 'tests/riscv-tests/isa/rv64ui-p-add': No such file make: *** [tests/riscv-tests-data/rv64ui-p-add] Error 1

 - After I removed the parentheses
```shell
➜  semu git:(master) vi mk/riscv-tests.mk 
➜  semu git:(master) ✗ git s                                    
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   mk/riscv-tests.mk

no changes added to commit (use "git add" and/or "git commit -a")
➜  semu git:(master) ✗ make ENABLE_RISCV_TESTS=1 clean run-tests
  CC    semu.o
  CC    tests/isa-test.o

(omitted)

Building riscv-tests...
configure: WARNING: using cross tools not prefixed with host triplet
[==========] Running 70 test(s) from riscv-tests.

(omitted)

[==========] 70 test(s) from riscv-tests ran.
[  PASSED  ] 54 test(s).

(omitted)
jserv commented 2 years ago

Thank @bugorz for contributing! I felt ashamed on the stupid mistake.

bugorz commented 2 years ago

@jserv No worries, this one is sneaky!