search

sysprog21 / simplefs

A simple native file system for Linux kernel
Other
374 stars 91 forks source link

Fix missing data synchronization #60

Closed HotMercury closed 3 months ago

HotMercury commented 3 months ago

The get_free_blocks function in simplefs has an issue where data written to the disk is not being properly synchronized.

Testing: The test flow is as follow. After step 4 the content of test.txt is empty.

  1. mount simplefs
  2. vim test.txt
  3. umount
  4. mount

Change: Add sync_dirty_buffer to ensure proper disk synchronization.

jserv commented 3 months ago

Can you improve the test suite to reflect the changes for data synchronization?

HotMercury commented 3 months ago

This means I need to improve my git message or add a test suite for GitHub Actions.

jserv commented 3 months ago

This means I need to improve my git message or add a test suite for GitHub Actions.

Exactly. That is the reason why we deploy CI pipeline.

jserv commented 3 months ago

Thank @HotMercury for contributing!