search

sysprog21 / vcam

Virtual camera device driver for Linux
MIT License
105 stars 45 forks source link

Pass v4l2-compliance on VIDEOC_CREATE_BUFS section #22

Closed kevinshieh0225 closed 2 years ago

kevinshieh0225 commented 2 years ago

The origin version fail on VIDEOC_CREATE_BUFS test when test case attempt to create with wrong format buffer and expect to see EINVAL return value.

While function vb2_ioctl_create_bufs relative to vb2ops.queue_setup , modify vcam_out_queue_setup for buffer size error check.

The implementation is reference from akvcam/buffers.c About vb2_ops.queue_setup version can be confirm from:

WayneLin1992 commented 2 years ago

Actually, vcam focuses on kernel v4.15 to v5.10+.

kevinshieh0225 commented 2 years ago

Thanks for @WayneLin1992 's comment. While it is no need to maintain version before v4.15, so I remove the version check