sysprog21 / vwifi

A virtual wireless device driver for Linux
MIT License
203 stars 39 forks source link

Correct the variable name in verify.sh #35

Closed willwillhi1 closed 1 year ago

willwillhi1 commented 1 year ago

Replace 'plot_rc' with 'final_ret'.

willwillhi1 commented 1 year ago

Is it okay to use the following commit message?

Subject: Fix exit code name typo Body: Replace 'plot_rc' with 'final_ret'.

jserv commented 1 year ago

Is it okay to use the following commit message? Subject: Fix exit code name typo Body: Replace 'plot_rc' with 'final_ret'.

Simply write "scripts: Correct the variable name to capture exit code" In the commit message body, you can mention the potential problem you have suffered.

willwillhi1 commented 1 year ago

Can it be changed to the following?

Subject: Correct variable name to capture exit code Body: 'plot_rc' does not represent the exit code, it should be changed to 'final_ret', so that the correct exit code can be obtained.

jserv commented 1 year ago

Can it be changed to the following?

You should amend git commit messages and force-push. Then, let's review. Talk is cheap. Show me the code.

jserv commented 1 year ago

Don't use git merge. Instead, use the following:

git remote add upstream https://github.com/sysprog21
git fetch upstream
git rebase upstream/main
git push --force
jserv commented 1 year ago

Thank @willwillhi1 for contributing!