search

sysr-q / flask-themes2

Easily theme your Flask app. (Flask-Themes with Flask>=0.6 support!)
Other
19 stars 14 forks source link

Python 3 support #2

Closed sh4nks closed 10 years ago

sh4nks commented 10 years ago

Any plans on supporting it?

sysr-q commented 10 years ago

I don't actually really have Python 3 w/ Flask installed since I deploy to 2.7.3 mainly. What particular issues rise up in py3k? I'll have a gander, since cross-compatibility would be fine.

sysr-q commented 10 years ago

Oh - I saw you seemed to have added it in your fork. If you want to send a pull request I'll merge it in and put it on the PyPI.

sh4nks commented 10 years ago

I also have modified the setup.py and merged the version.py into the __init__.py. This is my first attempt to port something to python3.. so any suggestions are welcome :)

sysr-q commented 10 years ago

I just did the bad version.py hack because I wanted to easily execfile() in the __version__ without having to remember to change it in two places. Feel free to open a pull request any time and I'll be more than happy to merge it in, it all looks pretty solid from my quick gander.