search

syssi / esphome-jk-bms

ESPHome component to monitor and control a Jikong Battery Management System (JK-BMS) via UART-TTL or BLE
Apache License 2.0
403 stars 134 forks source link

fix heating frame position #457

Closed RFDarter closed 3 months ago

RFDarter commented 4 months ago

My initial PR to add heating did not take the offset into account since i thought my device is a 24s version, but i turnes out it is a 32s. So my findings in the bluethooth snoops would need to take the offset into account.

syssi commented 4 months ago

Do you think we should remove the old style examples again?

RFDarter commented 4 months ago

Do you think we should remove the old style examples again?

Not sure. Mybe there are some devices with the latest hardware version, but the old style bms that would use protocol_version: JK02_24

https://github.com/syssi/esphome-jk-bms/issues/454 If his device works with protocol_version: JK02_24 we would need to keep them