syssi / esphome-pipsolar

ESPHome component to monitor and control a pipsolar inverter via RS232
Apache License 2.0
85 stars 37 forks source link

PIP 8048 wrong "current_max_ac_charging_current" #41

Closed gio-dot closed 1 year ago

gio-dot commented 1 year ago

Hi, thank you for your work! Today i tested setting of ac charging current, but i noticed that inverter doesn't load the correct value. TO do so i created simply buttons to load 2A and 10A; in both cases a wrong value is loaded by the inverter.

image

2022-12-09 17_50_31-HA Virtual 3T

photo_2022-12-10_01-24-59

gio-dot commented 1 year ago

Ok, solved with this mod.:

2022-12-15 13_22_06-__192 168 1 105_config_esphome_components_pipsolar_output___init__ py - Visual S

gio-dot commented 1 year ago

Hi, i need some help to solve completely "current_max_ac_charging_current" issue. As i said, original component command don't work in 8048 (this is because it has only 2 digit but 8048 uses 3 digit for ac charing current, due to the max 120A). I partially solved with the mod in the previous post but unfortunately even if now the current set is working, often esp32 crash.

I noticed that there is some issue in decoding MUCHGC command with my modification as you can see in attached screenshot. SOmetime it pass even if there is some garbage, sometimes it make esp32 crashing. I'm not expert in c++ at all, so i can't solve this issue for myself. Can someone help to get MUCHGC command properly working? Thank you

2022-12-24 01_01_49-Home Assistant 3T - ESPHome – Home Assistant

image

altabrida commented 1 year ago

Sorry for my English, I am a French Canadian.

CONF_CURRENT_MAX_CHARGING_CURRENT: ([10, 20, 30, 40, 50, 60, 70, 80, 90, 100, 110, 120], "MCHGC0%03.0f"), --> ... "MCHGC%03.0f"

I had a similar problem and I solved it. I removed the Zero in front of the sign of % because I noticed that it was normally served unit 0 in a parallel system. But in certain version of the protocol it is not required. MNCHGC

But finally I had to put it back because my inverter model needs it. My problem came more early on the %02.0f -> %03.0f So you help me a lot.

I ave 2 x MppSolar LV6548 for 120/240vac and i use the PIP 8048

altabrida commented 1 year ago

sorry i a copy the worng line

CONF_CURRENT_MAX_AC_CHARGING_CURRENT: ([2, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100, 110, 120], "MUCHGC0%03.0f"), CONF_CURRENT_MAX_AC_CHARGING_CURRENT: ([2, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100, 110, 120], "MUCHGC%03.0f"),

SeByDocKy commented 1 year ago

sorry i a copy the worng line

CONF_CURRENT_MAX_AC_CHARGING_CURRENT: ([2, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100, 110, 120], "MUCHGC0%03.0f"), CONF_CURRENT_MAX_AC_CHARGING_CURRENT: ([2, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100, 110, 120], "MUCHGC%03.0f"),

I updated the code with your modification but for my PIP8048 (120A), i still have bad values...

SeByDocKy commented 1 year ago

Hello all,

I fixed the current_max_ac_charging_current. In fact, the manual I had was wront. For modern voltrinic there are now 4 digits !!!. Tested for the Axpert max 1 and 2.

image

I also extend the buffer command to 12 chars to accept this new format

syssi commented 1 year ago

Good job!

SeByDocKy commented 1 year ago

Good job!

I will introduce a new select with this output command since the interval [2, 10, 20, ...., 120] is a bit weird for a number...

SeByDocKy commented 1 year ago
syssi commented 1 year ago

@SeByDocKy Could you extend the two example configuration of the feature branch accordingly? Thanks in advance!

esp32-example.yaml
esp8266-example.yaml
SeByDocKy commented 1 year ago

@SeByDocKy Could you extend the two example configuration of the feature branch accordingly? Thanks in advance!

esp32-example.yaml
esp8266-example.yaml

You mean you pushed also modifications for non 8048 branches ?

syssi commented 1 year ago

No. :-) Your feature branch (pip8084) contains two example configurations:

https://github.com/syssi/esphome-pipsolar/blob/pip8048/esp32-example.yaml https://github.com/syssi/esphome-pipsolar/blob/pip8048/esp8266-example.yaml

Could you extend these configurations to promote/document the new features here?