search

syssi / xiaomi_fan

Xiaomi Mi Smart Fan integration for Home Assistant
Apache License 2.0
428 stars 118 forks source link

Fix dmaker.fan.p39 rotate #232

Closed traysh closed 1 year ago

traysh commented 1 year ago

https://github.com/syssi/xiaomi_fan/pull/230 had the side effect of removing support for rotate commands for dmaker.fan.p39. This PR restores it, backporting and adapting code from current python-miio repo.

traysh commented 1 year ago

@syssi do I need to do anything to get this merged?

syssi commented 1 year ago

@traysh Done. Could you test the develop branch and provide some feedback? If it's working as expected I will prepare a new release.

traysh commented 1 year ago

@syssi sure, doing it right now

traysh commented 1 year ago

@syssi yes it works as expected