search

systamental / cryptodatapy

CryptoDataPy is a python library that makes it easy to build high quality data pipelines for the analysis of cryptoassets
Apache License 2.0
11 stars 4 forks source link

Python 3.8.10 pytest issues #2

Closed closedLoop closed 3 months ago

closedLoop commented 2 years ago

running python -m pytest --maxfail=1

after following install instructions for python 3.8.10. This appears to be a selenium issue

================================= 16 errors in 1.21s =================================
================================ test session starts =================================
platform linux -- Python 3.8.10, pytest-7.1.3, pluggy-1.0.0
rootdir: /home/sean/repos/systemental/cryptodatapy
plugins: cov-3.0.0
collected 0 items / 1 error                                                          

======================================= ERRORS =======================================
________________________ ERROR collecting tests/test_ccxt.py _________________________
ImportError while importing test module '/home/sean/repos/systemental/cryptodatapy/tests/test_ccxt.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_ccxt.py:4: in <module>
    from cryptodatapy.extract.datarequest import DataRequest
src/cryptodatapy/__init__.py:6: in <module>
    from cryptodatapy import(
src/cryptodatapy/util/__init__.py:1: in <module>
    from cryptodatapy.util.datacatalog import DataCatalog
src/cryptodatapy/util/datacatalog.py:5: in <module>
    from selenium import webdriver
E   ModuleNotFoundError: No module named 'selenium'
closedLoop commented 2 years ago

rebuilding poetry.lock resulted in this 

  SolverProblemError

  The current project's Python requirement (>=3.9) is not compatible with some of the required packages Python requirement:
    - selenium requires Python ~=3.7, so it will not be satisfied for Python >=4.0

  Because selenium (4.4.3) requires Python ~=3.7
   and no versions of selenium match >4.4.3,<5.0.0, selenium is forbidden.
  So, because cryptodatapy depends on selenium (^4.4.3), version solving failed.
closedLoop commented 2 years ago

Resolved with pyproject.toml and poetry.lock updates in https://github.com/systamental/cryptodatapy/pull/4