systelab / systelab-components

Systelab Angular common components
MIT License
14 stars 8 forks source link

Feature 775 counter in submit button #776

Closed OscarDeDios closed 1 year ago

OscarDeDios commented 1 year ago

PR Details

Added the selected items counter in the submit button in searcher dialog component. Optional parameter showSelectedRowsInSubmitButton as default false

Related Issue

https://github.com/systelab/systelab-components/issues/775

How Has This Been Tested

Added parameter in showcase and test in spec

Types of changes

Checklist

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (87c8ff4) 54.67% compared to head (baedf0f) 55.04%.

:exclamation: Current head baedf0f differs from pull request most recent head b71accf. Consider uploading reports for the commit b71accf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 15.3.x #776 +/- ## ========================================== + Coverage 54.67% 55.04% +0.36% ========================================== Files 126 126 Lines 3488 3490 +2 Branches 604 605 +1 ========================================== + Hits 1907 1921 +14 + Misses 1478 1463 -15 - Partials 103 106 +3 ``` | [Files](https://app.codecov.io/gh/systelab/systelab-components/pull/776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=systelab) | Coverage Δ | | |---|---|---| | [...ents/src/lib/searcher/searcher.dialog.component.ts](https://app.codecov.io/gh/systelab/systelab-components/pull/776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=systelab#diff-cHJvamVjdHMvc3lzdGVsYWItY29tcG9uZW50cy9zcmMvbGliL3NlYXJjaGVyL3NlYXJjaGVyLmRpYWxvZy5jb21wb25lbnQudHM=) | `52.00% <100.00%> (+2.00%)` | :arrow_up: | | [...nts/src/lib/searcher/searcher.dialog.parameters.ts](https://app.codecov.io/gh/systelab/systelab-components/pull/776?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=systelab#diff-cHJvamVjdHMvc3lzdGVsYWItY29tcG9uZW50cy9zcmMvbGliL3NlYXJjaGVyL3NlYXJjaGVyLmRpYWxvZy5wYXJhbWV0ZXJzLnRz) | `100.00% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/systelab/systelab-components/pull/776/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=systelab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.