Closed OscarDeDios closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 57.02%. Comparing base (
1809bac
) to head (f0bcdf8
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
PR Details
Add and remove doesn't clean the checkboxes after remove elements.
The new angular 17 @for {} in templates needs a "track" field with a key element of the array for performance. add and remove is an abstract class then the key element should be set in each use of the component then is a breaking change, it would have to review all the uses of the component. The use of index as a track only works if the list doesn't change.
Then in this case is better to use the traditional *ngFor
Related Issue
https://github.com/systelab/systelab-components/issues/837
How Has This Been Tested
Tested in the showcase
Types of changes
Checklist