PR Details

Combobox: change default behavior from sizeColumnsToFit to autoSize,added tooltips
Listbox: change default behavior from sizeColumnsToFit to autoSize, added tooltips, pinned multiple selection checkbox to the left
AbstractGrid: added input parameter to change behavior from sizeColumnsToFit to autoSize

Description

Add the possibility to horizontal scroll in the cases that it is needed in listboxes, comboboxes and grids. On listboxes and comboboxes, also add a tooltip by default so you can see the full value without having to scroll.

Related Issue

#857

Motivation and Context

When the cell value is longer than the container display itself, the value appears clipped and there is no possibility for the user to see the whole value description.

How Has This Been Tested

Test locally trying all the affected components of the showcase.

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] I have read the CONTRIBUTING document
[x] My code follows the code style of this project
[x] My change requires a change to the documentation
[x] I have updated the documentation accordingly (README.md for each UI component)
[ ] I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
[x] All new and existing tests passed
[x] A new branch needs to be created from master to evolve previous versions
[x] Increase version in package.json following Semantic Versioning
[ ] All UI components must be added into the showcase (at least 1 component with the default settings)
[x] Add the issue into the right project with the proper status (In progress)

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 77.01149% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 57.21%. Comparing base (521402f) to head (8e9464c).

Files	Patch %	Lines
...-components/src/lib/helper/autosize-grid-helper.ts	66.66%	12 Missing and 1 partial :warning:
...components/src/lib/grid/abstract-grid.component.ts	66.66%	4 Missing and 1 partial :warning:
...ts/src/lib/combobox/abstract-combobox.component.ts	91.66%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #858 +/- ## ========================================== + Coverage 56.99% 57.21% +0.22% ========================================== Files 130 131 +1 Lines 3667 3735 +68 Branches 645 658 +13 ========================================== + Hits 2090 2137 +47 - Misses 1465 1485 +20 - Partials 112 113 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carlosra85 commented 4 months ago

I think that, in order to avoid changing the behavior of the current users of the Systelab components, it would have been a good idea to make the behavior configurable (maintain the old behavior or apply the new one). Said that, I think that the change is correct.

We discussed this also in the task force meeting and they were accepted by default since are needed improvement and had no negative impact

systelab / systelab-components

AutoSize Grid Management Horizontal Scroll #858