systelab / systelab-components

Systelab Angular common components
MIT License
14 stars 8 forks source link

871 fixed download button behaviour #872

Closed p-riera closed 2 months ago

p-riera commented 3 months ago

PR Details

Changed html template to make the button react to clicks correctly

Related Issue

871

Motivation and Context

It fixes download button behaviour

How Has This Been Tested

showcase, manual test, small html change

Types of changes

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.16%. Comparing base (a591f6e) to head (753e672).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #872 +/- ## ========================================== - Coverage 57.27% 57.16% -0.11% ========================================== Files 131 131 Lines 3738 3738 Branches 658 658 ========================================== - Hits 2141 2137 -4 - Misses 1485 1488 +3 - Partials 112 113 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

XavierCalvo commented 2 months ago

Tricky! Great.