search

system76 / bottle

Protobuf messages in a bottle
GNU General Public License v3.0
9 stars 6 forks source link

Support filtering by status #46

Closed doomspork closed 3 years ago

doomspork commented 3 years ago

For the Assembly Service's gRPC call we need filter the requested builds otherwise we're going to end up with way more than we need.

Open to suggestions. I'm on the fence about whether we should allow multiple statuses to be requested at once or request multiple gRPC calls. For this MVP we don't need to worry about showing all the built builds but when we do get to that phase, we'll need to consider pagination for our gRPC calls.

btkostner commented 3 years ago

Alternatively instead of a ListBuilds we could do a ListAwaitingBuilds function, but that's more bike shedding

doomspork commented 3 years ago

Since we're going to hold off on this, I'm going to close the PR for now :+1: