search

system76 / bottle

Protobuf messages in a bottle
GNU General Public License v3.0
9 stars 6 forks source link

Update core timestamp to string to match other date fields #60

Open btkostner opened 3 years ago

btkostner commented 3 years ago

Updates the core bottle timestamp to a string for ISO datetime like all the other datetime fields we have.

This will need a change to the elixir branch as well.

doomspork commented 3 years ago

Let's hold off on this as it doesn't really add value but does case a pretty good breaking change.

The original justification for the ISO was that the database stores DateTime, not timestamps, so we do a bunch of conversion. The message envelope doesn't need to be human readable and using timestamps makes certain things at that level of the process simpler.