system76 / docs

System76 support documentation site
https://support.system76.com
309 stars 400 forks source link

Update system-firmware.md #1243

Closed esplinr closed 3 months ago

esplinr commented 3 months ago

Make clear what happens if the firmware updater is run with external devices plugged in.

esplinr commented 3 months ago

Is there anything else I need to do for this contribution to be accepted?

jacobgkau commented 3 months ago

@ahoneybun You replaced one linter issue with another. Let me take a look at what it needs.

esplinr commented 3 months ago

Thank you for merging. This problem has repeatedly caught me off-guard since I bought my laptop from System76. Hopefully having the hint be explicit will help me remember next time. I agree that it would be much better for the updater to show an error instead of silently restarting. The current behavior is baffling if you don't remember what a successful update should look like.