system76 / ec

System76 Open Source Embedded Controller
GNU General Public License v3.0
318 stars 72 forks source link

Feature Request/Suggestion: Remember Camera Toggle State or Make it Configurable in Settings #447

Open ilikenwf opened 6 months ago

ilikenwf commented 6 months ago

I rarely if ever use the camera, it would be nice to have the ability to have the EC either use the last used state (enabled/disabled) or allow me to set a default of enabled/disabled in the settings.

I'm using a serw13, however I'm sure it would be welcome in all models with the feature.

crawfxrd commented 6 months ago

Camera power is always enabled. It's not configurable.

ilikenwf commented 6 months ago

Then why does the camera in the serw13 disappear from lsusb when the disable hotkey is used?

crawfxrd commented 6 months ago

Oh, I didn't even realize that that's what we used that icon for.

Anyways, the only persistent "config" is the custom keyboard layout. Any other settings, like battery charging thresholds, are lost on EC reset.

See: #256

I suppose the first thing to do would to be able to set the default state at build time.

ilikenwf commented 6 months ago

My current custom build includes some of the pending pr's for backlight settings on the keyboard, but yes, it's a handy feature, though with the open EC, mostly open UEFI, and in my build the ME fully stripped, there's little to no actual threat at the low level...

Everything threatening is in userspace.

I've been using this for months without issues:

https://github.com/corna/me_cleaner/pull/384

That mention would be better in coreboot I realize, but even so...food for thought. That PR allows both deblobbing the ME somewhat as well as the HAP bit or disable bit or whatever the name of it is now.