system76 / ec

System76 Open Source Embedded Controller
GNU General Public License v3.0
318 stars 72 forks source link

Replace hard-coded fan assumptions with configs #453

Open crawfxrd opened 4 months ago

crawfxrd commented 4 months ago

There are some hard-coded assumptions around fans that need to be addressed:

darp10 is a unit without a dGPU, but has 2 CPU fans. They use PWM2 and PWM3.

It should be possible for a board to specify which interface each fan uses.

Info that's probably needed for each fan:

Shoving it all in the Makefile probably won't work, requiring some rewriting of the common and board-level logic.

Additionally, the temperature sensors should be pulled out and be separate from the fan control, but that fits more with #390.