Support second fan without dGPU

crawfxrd commented 2 months ago

Fan logic in dgpu, peci modules is moved to fan module
CPU (PECI) fan is renamed to FAN1
dGPU fan is renamed to FAN2
Boards must now define which PWM channel is used for each fan
Boards must now always define their fan points
darp10 can now have fan points for the second fan

Behavioral changes:

ectool: Fans are now indexed from 1 instead of 0

Test on:

Unit with 1 fan
Unit with dGPU (2 fans)
darp10 (2 fans, no dGPU)

Requires: system76/coreboot#222 Includes: #454, #456, #457, #481 Unblocks: #390

XV-02 commented 1 month ago

With this PR, how should ectool report fan speeds?

Looking at a gaze16-3060-b as the dGPU system, it looked like ectool reported fan speed as an 8-bit value between 0 and 255 (inclusive). sensors reports rpm values which look correct, however.

crawfxrd commented 1 month ago

ectool fan reads/writes from the duty cycle register (DCRi), so uses a value of 0-255.

system76 / ec

Support second fan without dGPU #474