system76 / edk2

EDK II
http://www.tianocore.org/edk2/
Other
1 stars 3 forks source link

Dynamically generated firmware configuration information page #18

Closed jackpot51 closed 4 years ago

jackpot51 commented 4 years ago

This mostly implements the firmware configuration screen. Most values are sourced dynamically. In the future, ME status and AMD IOMMU status will need to be sourced dynamically.

It has been desired to have a webcam indicator in BIOS as well, I need to investigate how to implement that.

Mockups:

firmware-info-mockup

In the real thing, Firmware Information Configuration was moved to below the boot option section:

actual-qemu

jacobgkau commented 4 years ago

There's a label to "move highlight," but there are no highlights on this page. (I see that the "move highlight" label was not in the mockup.) Is that not something that can be hidden on this screen since there's nothing that can be highlighted?

jackpot51 commented 4 years ago

There's a label to "move highlight," but there are no highlights on this page. (I see that the "move highlight" label was not in the mockup.) Is that not something that can be hidden on this screen since there's nothing that can be highlighted?

Yeah, that can probably be done

jackpot51 commented 4 years ago

@jacobgkau implemented that in https://github.com/system76/firmware-setup/commit/ae3ee51a977386c8aab048adfe9ebca6e9192394