system76 / firmware-open

System76 Open Firmware
Other
951 stars 86 forks source link

First boot after flashing results in power off #139

Open crawfxrd opened 3 years ago

crawfxrd commented 3 years ago

After successfully flashing from proprietary firmware to firmware-open, the machine powers off.

Expected behavior

The machine turns on, powers off for ~2 seconds, and then turns back on.

Actual behavior

The machine turns on, powers off, and remains off.

Notes

Tested on:

gaze15:

[12:20:11] 28: Power switch press
[12:20:11] 28: power_on_s5
[12:20:11] VA_EC_EN = true
[12:20:11] DD_ON = true
[12:20:11] SUS_PWR_ACK = true
[12:20:11] EC_RSMRST_N = true
[12:20:11] POWER_STATE_S0
[12:20:11] 28: ALL_SYS_PWRGD asserted
[12:20:11] PM_PWROK = true
[12:20:11] 2D: Power switch release
[12:20:11] 2D: PLT_RST# de-asserted
[12:20:11] Enable PNP devices
[12:20:11] POST: 0x34
[12:20:11] MRC: no data in 'RW_MRC_CACHE'
[12:20:12] POST: 0x36                       # POST_MEM_PREINIT_PREP_END
[12:20:12] POST: 0x92                       # POST_FSP_MEMORY_INIT
[12:20:12] POST 0B00
[12:20:12] POST 0B02
[12:20:12] POST DC0F                        # CpuAddPreMemConfigBlocks Done
[12:20:12] POST DB49                        # Pre-Mem Program HSIO
[12:20:12] POST DC3F                        # TxtInit Start
[12:20:12] POST DC13
[12:20:12] POST: 0x98                       # POST_FSP_MEMORY_EXIT
[12:20:12] POWER_STATE_S5
[12:20:12] 69: ALL_SYS_PWRGD de-asserted
[12:20:12] PM_PWROK = false
[12:20:12] 69: PLT_RST# asserted
[12:20:12] 69: power_off_s5
[12:20:12] PM_PWROK = false
[12:20:12] EC_RSMRST_N = false
[12:20:12] DD_ON = false
[12:20:12] VA_EC_EN = false
[12:20:12] POWER_STATE_DS5

(comments taken from coreboot source and FSP integration guide)

jacobgkau commented 3 years ago

For what it's worth, we've considered this expected behavior and added a note to the support article that powering on more than once may be necessary after flashing is complete. There's also a PR open to add similar messaging in the Firmware Manager app. If/when this gets fixed, we may want to remove the corresponding notes from the documentation and GUI.

crawfxrd commented 2 years ago

Cause may not be the same, but this is going to become very apparent after the coreboot update. coreboot will issue a global reset after changing the IME mode to put it in the correct state.