search

system76 / firmware-open

System76 Open Firmware
Other
949 stars 86 forks source link

scripts: Version EC separately from SBIOS #438

Open crawfxrd opened 1 year ago

crawfxrd commented 1 year ago

Stop setting the EC version to the SBIOS version so that the EC will use its real version.

The original rationale for having the EC version match the SBIOS version was to ensure that compatible versions of each were installed. So we set the EC version to the SBIOS version and always flash both of them, even if only one actually changed.

At some point, a mechanism should be implemented that checks for a minimum supported/compatible version. This would be comparable to the LVFS MetaInfo's "requires" field. (UEFI requires the firmware version be a 32-bit unsigned integer, which would simplify the comparison.)

Resolves: #434

crawfxrd commented 1 year ago

This could be simplified by having the EC only support building a single version. That is, put everything in build/<model>/ (single version per model) or even just build/ (single version for a single model) instead of build/<model>/<version>/.

I don't expect that to affect anyone but me, since I regularly diff the *.asm and ec.mem files when building. But that's more of a convenience; I can just copy the build output somewhere else.