system76 / firmware-open

System76 Open Firmware
Other
944 stars 84 forks source link

scripts: Remove explicit rustup self update #531

Closed crawfxrd closed 3 months ago

crawfxrd commented 4 months ago

Commit 7d6a15e63c95 ("Convert toolchain file to TOML syntax") switched from the bare toolchain file to the TOML-based one for better management of the toolchain and components used.

Commit cf7fc2c540d5 ("scripts: Update rustup or inform user of env vars") added an explicit rustup self update because there were still cases, a year later, of people not having a rustup new enough to support the TOML-based toolchain file.

Now 2 years after that, it should be safe to drop the explicit self update. The TOML format has widespread adoption and rustup now self updates by default. This should allow distro-provided rustup, which disables the self update feature, to work if it is already installed in place of the one downloaded from https://rustup.rs.