search

system76 / firmware-update

System76 Firmware Update Utility
GNU General Public License v3.0
204 stars 15 forks source link

Compact SMMSTORE on upgrade #32

Closed crawfxrd closed 3 years ago

crawfxrd commented 3 years ago

Due to system76/firmware-open#145, upgrades cannot happen until the SMMSTORE region is compacted/cleared.

As commented in #29, a possible solution is to compact the store. This could happen either always on upgrade, or only when an error is detected with SMMSTORE (which currently happens when setting the override key).

crawfxrd commented 3 years ago

~This can be done with firmware-smmstore, but it won't solve the reported issue in firmware-open. To do that would require not calling through the SMI interface, which I'm not sure is feasible.~

It looks like it would be sufficient to just copy the compact logic from firmware-smmstore and perform it on the memory slice when copied in app/bios.rs.

crawfxrd commented 3 years ago

No longer valid. Systems will use SMMSTOREv2 in the next update. Data will need to be migrated from SMMSTOREv1 to the NV Data FV format used by edk2.