jacobgkau
commented
3 years ago I see the new output including the Entering scratch ROM message, only when going from proprietary Clevo firmware to Open Firmware (Open-to-proprietary and Open-to-Open still show Programming EC Main ROM.)
I'm not sure how necessary it was to change the message at the end of the process from System will shut off in 5 seconds to EC will reset in 5 seconds-- to a non-technical user, "reset" might sound like it should turn back on by itself (which it doesn't.) The rest of this output is fairly technical anyway, though, so if this is more accurate, I guess it's not a problem.
Tested on the following:
- oryp7, Clevo -> Open and Open -> Clevo.
- gaze15, Open -> Clevo and Clevo -> Open.
- lemp10, Open -> Clevo, Clevo -> outdated Open, outdated Open -> latest Open, latest Open -> Clevo, and Clevo -> latest Open.
Haven't seen any problems yet. (Flashing to lemp10's outdated firmware required unplugging the AC adapter, but I confirmed that was an issue with the older firmware version I picked to test with, not the new flash_legacy function.) Holding on approval for further testing per @leviport.
leviport
crawfxrd
jackpot51
This implements the legacy EC flashing protocol in firmware-update and uses it when flashing System76 EC on top of legacy EC so we can control when the EC gets reset.
This will affect any transitions between proprietary and open firmware, so other models should be tested as well.