system76 / firmware-update

System76 Firmware Update Utility
GNU General Public License v3.0
204 stars 15 forks source link

Defer unlock prompt until update is accepted #82

Closed crawfxrd closed 1 year ago

crawfxrd commented 1 year ago

Move unlocking from EC validation to the main app update logic. This allows users to accept updating before unlocking, or cancel without unlocking.

This does not resolve the issue of returning to firmware-update when canceling/failing the unlock prompt, as the boot override still exists.

The UX for this needs additional improvements.

TEST:

Resolves: #81 Partially resolves: https://github.com/system76/firmware-open/issues/405

XV-02 commented 1 year ago

I looked at:

And all three worked as I believe is expected:

I also made sure to test a drive with the wrong firmware, which correctly errors out.

That sounds good?