system76 / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
93 stars 33 forks source link

Include layer 3 and 4 in default layout for launch_1 #12

Closed ids1024 closed 3 years ago

ids1024 commented 3 years ago

I added support for layer 3 and 4 to the Configurator, but it seems to load bogus values.

dynamic_keymap_reset() has a comment saying:

// Reset the keymaps in EEPROM to what is in flash.
// All keyboards using dynamic keymaps should define a layout
// for the same number of layers as DYNAMIC_KEYMAP_LAYER_COUNT

Other keyboards seem to have default layouts that only list the first two layers while setting DYNAMIC_KEYMAP_LAYER_COUNT to 4, but whatever. This appears to make the Configurator behave as expected with layer 3 and 4.