search

system76 / qmk_firmware

Open-source keyboard firmware for Atmel AVR and Arm USB families
https://qmk.fm
GNU General Public License v2.0
93 stars 33 forks source link

Backlight keycodes matching EC behavior #7

Closed ids1024 closed 3 years ago

ids1024 commented 3 years ago

This makes the backlight brightness up, down, and toggle keys work in a way that matches the EC. (I guess it shouldn't have 255 as the max; in which case the values will need to be adjusted).

The EC also has a color key. But what do we want here, since there are both colors and patterns that can be set?

I'm not sure this is really what we want (I guess it's just how Clevo decided to do things), but we'll want some kind of support for controlling the backlight through keys, and it makes sense to be consistent with the EC's behavior for internal keyboards.

jackpot51 commented 3 years ago

Cherry picked this and made improvements in master