search

system76 / thelio-io-windows

WIP Windows driver for System76 Thelio Io
GNU General Public License v3.0
16 stars 8 forks source link

wix: Auto-generate produce Id GUID #4

Closed ids1024 closed 3 years ago

ids1024 commented 3 years ago

This ID needs to be changed for every new version. I'm not aware there's any reason not to let WiX generate it.

jackpot51 commented 3 years ago

If this is changed, the installer will be allowed to install a duplicate without uninstalling the old version. I haven't found a workaround for this, other than using the same product guid for all

ids1024 commented 3 years ago

Yeah, it's weird how Windows Installer works that way. I think using the same product Id can cause some problems; not entirely sure how that will behave.

In the Configurator I used AllowSameVersionUpgrades="yes" which seems to make it work sensibly.

Edit: Amended to add that.

jackpot51 commented 3 years ago

Good find, this is better