search

systemapic / systemapic.js

Systemapic Javascript API
https://systemapic.com
0 stars 3 forks source link

add filter for spectators of project #48

Closed IgorZiegler closed 8 years ago

IgorZiegler commented 8 years ago

19

knutole commented 8 years ago

Very nice. See my comment on #19 :)

knutole commented 8 years ago

additional features

  1. i think we should add one more thing -> when you write name, and filter, the top result should be marked "active " (light blue background for example), and when user presses [Enter] before writing any more, the top item will be automatically selected and added to box.
  2. the items that are not allowed to select (like own user), should be filtered out of the box. Like here, knutole is not allowed to select, cause it's the logged-in user. So it should be removed from list also: screen shot 2016-02-09 at 2 46 04 pm

Will verify that it works as expected, then we merge :+1:

knutole commented 8 years ago

Bugs

  1. Using [Enter] doesn't work. So, the user when writing in the input box, should get a filtered list. Then, if pressing [Enter] button (before writing whole name), the top-most search hit should be selected. screen shot 2016-02-09 at 6 58 51 pm screen shot 2016-02-09 at 6 58 40 pm In the first image (Jorgen), pressing [Enter] doesn't do anything (or it adds the wrong user). In the second image (Igor), the user Igor is highligted, and when pressing [Enter] the user is added to input correctly.

The trick is to make sure the top-most user in the filtered list is always "highlighted", so that it will be added on [Enter].

knutole commented 8 years ago

@IgorZiegler how is this going? fixed?