systemart / rtgui

Automatically exported from code.google.com/p/rtgui
0 stars 0 forks source link

Random 0.2.6 nitpicks. #58

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
After a few minutes with diff and hacking in my changes, here is my rather
pedantic list of "bugs" and/or changes (attached).  Disclaimer: Not a
proper patch.

A quick run through:
1. When updated via JS, the "remain" column collapses without  .  Not
sure why -- maybe just some bad CSS or browser rendering on my end.
2. Replaced tabs with spaces in certain lines of style.css.
3. Added quotes for a class name in subModal.js.  Optionally, adds
click-outside-modal to hide.
4. More general nitpicking.  Ignore the style changes; too lazy to diff
another copy.  :p  Puts ending columns into {$col}last class; strips extra
white space at the end of one div; removes extra space in one tag.

Looks to be a great release.  Best wishes!

Original issue reported on code.google.com by llamaXxX@gmail.com on 12 Dec 2008 at 12:18

Attachments:

GoogleCodeExporter commented 9 years ago
Hi Llama...

Once again, thanks for your excellent work at finding bugs in my crap code!
1. Yeah - I noticed this too.  I think the problem is that a <div> with just 
whitespace in is pruned by browsers, making the other columns shift up.  Your 
solution using a &nsbp; is good (and the same as the other columns).  
Accepted/Fixed 
for next release.

2. Tabs/spaces - all whitespace?  Anyway - accepted!

3. Yup - you noticed my hacking here too! all accepted.

4. I tried changes to view.php (in FF and Opera / Linux/Windows), but not good 
for 
me - layout broken :(  

Original comment by lemonbe...@gmail.com on 12 Dec 2008 at 8:13

GoogleCodeExporter commented 9 years ago
Fixed in version 0.2.7

Original comment by lemonbe...@gmail.com on 16 Mar 2009 at 10:19