systemd / casync

Content-Addressable Data Synchronization Tool
1.5k stars 117 forks source link

Use libdir to install protocols #138

Open bl33pbl0p opened 6 years ago

bl33pbl0p commented 6 years ago

We pass something like:

meson --prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/bin \ --libdir=/usr/x86_64-pc-linux-gnu/lib --libexecdir=/usr/x86_64-pc-linux-gnu/libexec ...

in exherbo, where /usr/lib is symlinked to /usr/$TARGET/lib, /usr/bin -> /usr/$TARGET/bin, and so on, but before this change they would be installed to /usr/lib, which does not work since that is a symlink as described above, so use the passed libdir to install protocols. Other *dirs were working correctly.

bl33pbl0p commented 6 years ago

It would also be nice to have a release soon, preferably after this gets merged. =)

fsateler commented 6 years ago

Something like this was attempted and rejected in https://github.com/systemd/casync/pull/106

bl33pbl0p commented 5 years ago

ping

keszybz commented 5 years ago

OK, OK, let's make this work. But please change the patch so that the default remains as it is now, and make libexecdir overridable. If -Dlibexecdir, install under libexecdir/casync, and otherwise keep the path that is used now.

keszybz commented 5 years ago

@bl33pbl0p ?

bl33pbl0p commented 5 years ago

Sorry, I kept missing this all this time.

Is this close to what you wanted (I'm not really great at meson)?

@keszybz