search

systemd / mkosi

💽 Build Bespoke OS Images
https://mkosi.systemd.io/
1.19k stars 321 forks source link

v20 - nspawn settings are no longer copied into place #2264

Closed NeilW closed 10 months ago

NeilW commented 10 months ago

For some reason v20 has stopped recognising the 'mkosi.nspawn' file, or the '--settings' command line.

It is no longer copied into the output directory.

Worked fine on v19.

DaanDeMeyer commented 10 months ago

@NeilW We still use it when running mkosi boot or mkosi shell but we've stopped copying it into the output directory. Do you explicitly want it to be copied to the output directory?

NeilW commented 10 months ago

As far as I'm aware machinectl pull-tar still looks for a tar file, the .nspawn file and the SHA256SUMS files - unless you've changed the way that works in systemd as well. 

$ sudo machinectl pull-tar --verify=checksum https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz
Enqueued transfer job 2. Press C-c to continue download in background.
Pulling 'https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz', saving as 'philosophers'.
Downloading 41B for https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.nspawn.
Acquired 41B.
Download of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.nspawn complete.
Downloading 81.8M for https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz.
Got 2% of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz. 1min 6s left at 1.2M/s.
Downloading 172B for https://github.com/NeilW/systemd-dining/releases/download/latest/SHA256SUMS.
Acquired 172B.
Download of https://github.com/NeilW/systemd-dining/releases/download/latest/SHA256SUMS complete.
Got 13% of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz. 15s left at 4.4M/s.
Got 25% of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz. 10s left at 5.7M/s.
Got 36% of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz. 8s left at 6.4M/s.
Got 46% of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz. 6s left at 6.6M/s.
Got 56% of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz. 5s left at 6.7M/s.
Got 65% of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz. 4s left at 6.8M/s.
Got 77% of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz. 2s left at 6.9M/s.
Got 88% of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz. 1s left at 7.1M/s.
Got 98% of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz. 175ms left at 7.1M/s.
Acquired 316.4M.
Download of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz complete.
SHA256 checksum of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.tar.xz is valid.
SHA256 checksum of https://github.com/NeilW/systemd-dining/releases/download/latest/philosophers.nspawn is valid.
Created new local image 'philosophers'.
Created new settings file /var/lib/machines/philosophers.nspawn.
Operation completed successfully.
Exiting.
DaanDeMeyer commented 10 months ago

Makes sense I'll make sure it gets copied to the output directory

DaanDeMeyer commented 10 months ago

@NeilW Give #2265 a try, that should fix it.

NeilW commented 10 months ago

That does the trick