systemd / package-notes

Tools to add packaging metadata to ELF files
16 stars 10 forks source link

ci: lint the codebase #22

Closed mrc0mmand closed 2 years ago

mrc0mmand commented 2 years ago

This PR introduces, so far, linting for shell scripts (shellcheck), perl (Perl::Critic), and python (pylint, isort). I'm not sure if we want to enable black and/or flake8 as well, since that'd require some tinkering (either in reformating the python code or writing custom configs), so please let me know.

Also, it wouldn't be a CI without issues, so there's a bug in super-linter, which causes perl and python scripts without an extension to get ignored. I'll bring this up in the super-linter repo, but until it's fixed I created a "dummy" directory (.github/super-linter-links) with "extension-ified" symlinks to the respective files without an extension, which works around this issue.

PTAL.