search

systemd / pystemd

A thin Cython-based wrapper on top of libsystemd, focused on exposing the dbus API via sd-bus in an automated and easy to consume way.
GNU Lesser General Public License v2.1
411 stars 36 forks source link

Include tests in the pypi tarball #1

Closed floppym closed 6 years ago

floppym commented 6 years ago

This allows Linux packagers to easily run the unit tests as part of the build process.

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

floppym commented 6 years ago

I've submitted the individual CLA form.

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

aleivag commented 6 years ago

Hi @floppym : this looks good, originally we did not wanted to ship the tests with the code, but you make a good case, i'll merge this after i check the #2 issue

Thank you for submitting this by the way!!!

aleivag commented 6 years ago

Hi @floppym i merged your diff with our internal tooling, thanks for contributing this!!!

aleivag commented 6 years ago

@floppym hey, our tooling screw up the commit and change the author... i'm activly working on fixing this and make you the author of the commit, sorry about that

floppym commented 6 years ago

@aleivag No worries; I'm not concerned about getting credit for a trivial change like this. Thank you for reviewing/merging.